search

mdx-js / eslint-mdx

ESLint Parser/Plugin for MDX
https://npmjs.org/eslint-plugin-mdx
MIT License
264 stars 32 forks source link

feat: resolve custom remark config on parsing #337

Closed JounQin closed 3 years ago

JounQin commented 3 years ago

close #336

codesandbox-ci[bot] commented 3 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov-commenter commented 3 years ago

Codecov Report

Merging #337 (478660c) into master (0feb2d3) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #337   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          510       507    -3     
  Branches       110       109    -1     
=========================================
- Hits           510       507    -3
Impacted Files Coverage Δ
packages/eslint-mdx/src/index.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/parser.ts 100.00% <100.00%> (ø)
packages/eslint-mdx/src/processor.ts 100.00% <100.00%> (ø)
packages/eslint-plugin-mdx/src/rules/remark.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0feb2d3...478660c. Read the comment docs.

JounQin commented 3 years ago

@wooorm Ready for a new release.

wooorm commented 3 years ago

Are the tests supposed to take 150 seconds and more? They seem to hang for me on remark.test.ts and fixtures.test.ts?

wooorm commented 3 years ago

jest is doing this sometimes for me, I’m not sure why. But running yarn again solved it 🤷‍♂️. Released!

JounQin commented 3 years ago

jest is doing this sometimes for me, I’m not sure why. But running yarn again solved it 🤷‍♂️. Released!

The dependencies tree changed a bit in this PR, so yarn install is required. 🤣

wooorm commented 3 years ago

I never have projects locally, nor yarn, so I installed both freshly though?

JounQin commented 3 years ago

Then I'm not sure what is happening too. 🤣

I'm not sure why, but it seems build is required before test again, it should work without build before...

Maybe look into this tomorrow or later.