Closed JounQin closed 2 years ago
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Merging #383 (1748bf1) into master (c497839) will not change coverage. The diff coverage is
100.00%
.
@@ Coverage Diff @@
## master #383 +/- ##
=======================================
Coverage 99.06% 99.06%
=======================================
Files 18 18
Lines 214 214
Branches 40 42 +2
=======================================
Hits 212 212
Misses 1 1
Partials 1 1
Impacted Files | Coverage Δ | |
---|---|---|
packages/eslint-plugin-mdx/src/configs/base.ts | 100.00% <ø> (ø) |
|
packages/eslint-mdx/src/parser.ts | 100.00% <100.00%> (ø) |
|
packages/eslint-mdx/src/traverse.ts | 100.00% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update c497839...1748bf1. Read the comment docs.
@wooorm Any time to review?
This looks good to me! Is that all that’s needed to update to MDX 2? 🤔
https://github.com/mdx-js/eslint-mdx/issues/384
There is another known issue for now.
@wooorm That issue doesn't block this PR, I think it's ready for a new next
release?
sure!
P.S. can you update deps (at least https://github.com/gajus/eslint-plugin-jsdoc/pull/880#issuecomment-1103673160) so everything builds on Node.js 18?
Released 2.0.0-next.2!
related https://github.com/micromark/micromark-extension-mdx-expression/pull/4
close #380