fix: same markdown processor cached for .md and .mdx

mdx-js / eslint-mdx

ESLint Parser/Plugin for MDX

https://npmjs.org/eslint-plugin-mdx

MIT License

259 stars 29 forks source link

fix: same markdown processor cached for .md and .mdx #401

Closed gyanta closed 2 years ago

gyanta commented 2 years ago

Closes #400

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

JounQin commented 2 years ago

@gyanta Sorry, please run prettier or eslint --fix locally or on GitPod.

gyanta commented 2 years ago

Oops, missed that - thanks @JounQin!

JounQin commented 2 years ago

Thanks for your contribution! @gyanta

gyanta commented 2 years ago

My pleasure, thanks for all your work on this!

JounQin commented 2 years ago

@wooorm I believe we can publish a stable v2 version now.

JounQin commented 2 years ago

ping @wooorm

wooorm commented 2 years ago

I’ll try to get to it tomorrow. Please ping me if I don’t!

wooorm commented 2 years ago

Are you sure everything is ready for a stable? 2.0.0? Exciting! I am guessing that yarn release will make a patch? How do you want me to release it?

JounQin commented 2 years ago

Are you sure everything is ready for a stable? 2.0.0? Exciting!

From my personal view, yes it's! I've been using the beta version for a long time.

I am guessing that yarn release will make a patch? How do you want me to release it?

I think yarn release will just do the right thing.

Or you can try yarn release --dry-run at least.

wooorm commented 2 years ago

I think it’s making a next release right now 🤔

wooorm commented 2 years ago

lerna publish major --conventional-commits --create-release github --yes

^-- this probably?

JounQin commented 2 years ago

(Lerna seems bad for version management for this point. 😅)

I've migrated to https://github.com/changesets/changesets for most of my projects.

JounQin commented 2 years ago

lerna publish major --conventional-commits --create-release github --yes

^-- this probably?

Maybe, hope it will work correctly. 😅

wooorm commented 2 years ago

nope :'(

lerna notice cli v4.0.0
lerna info current version 2.0.0-next.6
lerna notice Current HEAD is already released, skipping change detection.
lerna success No changed packages to publish

Is there like a force flag?

JounQin commented 2 years ago

@wooorm

https://github.com/mdx-js/eslint-mdx/pull/396#issuecomment-1126907016

You'd better to do dry-run first?

JounQin commented 2 years ago

@wooorm

Or force push back the latest commit first to generate a correct changelog?

wooorm commented 2 years ago

boom, worked!

wooorm commented 2 years ago

Can you manage the release notes?

JounQin commented 2 years ago

Can you manage the release notes?

Yes, just going to do this and change the changelog manually.

JounQin commented 2 years ago

Done! https://github.com/mdx-js/eslint-mdx/releases/tag/v2.0.0