mdx-js / eslint-mdx

ESLint Parser/Plugin for MDX

https://npmjs.org/eslint-plugin-mdx

MIT License

259 stars 29 forks source link

fix: add missing unist-util-visit and vfile deps #405

Closed JounQin closed 2 years ago

JounQin commented 2 years ago

close #404

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

codecov-commenter commented 2 years ago

Codecov Report

Merging #405 (98013f6) into master (4283717) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master      #405   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           16        16           
  Lines          195       195           
  Branches        40        40           
=========================================
  Hits           195       195

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4283717...98013f6. Read the comment docs.

JounQin commented 2 years ago

Ready for a new release @wooorm

Both v1 and v2, thanks!

wooorm commented 2 years ago

Can you land it on v1 too, so that I can release it?

JounQin commented 2 years ago

Can you land it on v1 too, so that I can release it?

v1 does not need this

wooorm commented 2 years ago

Oh you meant: release both. I read it as: release this on both! 👍

So you have a recommendation for how to release the v1 branch?

wooorm commented 2 years ago

I released v2

JounQin commented 2 years ago

Oh you meant: release both. I read it as: release this on both! 👍

So you have a recommendation for how to release the v1 branch?

@wooorm

There is a release-v1 branch, you release v1 as usual.

wooorm commented 2 years ago

That would likely create a latest release on npm? But I need to release under a different npm tag. Similar to the release-next script. Or does yarn release do that magically?

JounQin commented 2 years ago

That would likely create a latest release on npm? But I need to release under a different npm tag. Similar to the release-next script. Or does yarn release do that magically?

Oh, I forget about that, maybe you update the dist tag in release-v1 branch?

wooorm commented 2 years ago

It worked! https://github.com/mdx-js/eslint-mdx/releases