mdx-js / eslint-mdx

ESLint Parser/Plugin for MDX
https://npmjs.org/eslint-plugin-mdx
MIT License
259 stars 29 forks source link

chore: release package(s) #415

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 2 years ago

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to master, this PR will be updated.

Releases

eslint-mdx@2.0.2

Patch Changes

eslint-plugin-mdx@2.0.2

Patch Changes

codesandbox-ci[bot] commented 2 years ago

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

JounQin commented 2 years ago

https://github.com/mdx-js/eslint-mdx/blob/master/CONTRIBUTING.md#packages-releasing-difference

@wooorm Let's release?

wooorm commented 2 years ago

The text reads:

When you're ready to do a release, you can merge this and publish to npm yourself [...]

So you can merge this first?

JounQin commented 2 years ago

@wooorm Done!

wooorm commented 2 years ago

It crashes:

$ changeset publish
🦋  info npm info eslint-mdx
🦋  info npm info eslint-plugin-mdx
🦋  info eslint-mdx is being published because our local version (2.0.2) has not been published on npm
🦋  info eslint-plugin-mdx is being published because our local version (2.0.2) has not been published on npm
🦋  info Publishing "eslint-mdx" at "2.0.2"
🦋  info Publishing "eslint-plugin-mdx" at "2.0.2"
🦋  error an error occurred while publishing eslint-mdx: EUNSCOPED Can't restrict access to unscoped packages. 
🦋  error npm notice Publishing to https://registry.npmjs.org/
🦋  error npm ERR! code EUNSCOPED
🦋  error npm ERR! Can't restrict access to unscoped packages.
🦋  error {
🦋  error   "error": {
🦋  error     "code": "EUNSCOPED",
🦋  error     "summary": "Can't restrict access to unscoped packages.",
🦋  error     "detail": ""
🦋  error   }
🦋  error }
🦋  error 
🦋  error npm ERR! A complete log of this run can be found in:
🦋  error npm ERR!     /Users/tilde/.npm/_logs/2022-07-23T14_00_50_192Z-debug-0.log
🦋  error 
🦋  error an error occurred while publishing eslint-plugin-mdx: EUNSCOPED Can't restrict access to unscoped packages. 
🦋  error npm notice Publishing to https://registry.npmjs.org/
🦋  error npm ERR! code EUNSCOPED
🦋  error npm ERR! Can't restrict access to unscoped packages.
🦋  error {
🦋  error   "error": {
🦋  error     "code": "EUNSCOPED",
🦋  error     "summary": "Can't restrict access to unscoped packages.",
🦋  error     "detail": ""
🦋  error   }
🦋  error }
🦋  error 
🦋  error npm ERR! A complete log of this run can be found in:
🦋  error npm ERR!     /Users/tilde/.npm/_logs/2022-07-23T14_00_50_194Z-debug-0.log
🦋  error 
🦋  error packages failed to publish:
🦋  eslint-mdx@2.0.2
🦋  eslint-plugin-mdx@2.0.2
wooorm commented 2 years ago

https://github.com/changesets/changesets/issues/503#issuecomment-766750858

JounQin commented 2 years ago

changesets/changesets#503 (comment)

Right, I forgot about that part, can you add it and release?

wooorm commented 2 years ago

I fixed it. Changesets does not seem to change CHANGELOG.md or GitHub releases. Is that intentional?

JounQin commented 2 years ago

I fixed it. Changesets does not seem to change CHANGELOG.md or GitHub releases. Is that intentional?

Change log has been changed in this PR.

wooorm commented 2 years ago

This file has not been changed: https://github.com/mdx-js/eslint-mdx/blob/master/CHANGELOG.md. GitHub releases have not changed either.

JounQin commented 2 years ago

The root changelog should be like https://github.com/un-ts/prettier/blob/master/CHANGELOG.md, I will raise another PR for it.

JounQin commented 2 years ago

GitHub releases have not changed either.

It seems createGithubReleases is only available when using publish on CI with its action, I'll do manual releases for now.

https://github.com/changesets/action/blob/6a46d2c28377497e64763ba5f1faeabbd3d88c33/src/run.ts#L94

I raised https://github.com/changesets/changesets/issues/885 for tracking.