fix: void attribute and empty attribute are different

[JounQin]

close #450

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: a82b6740faf6bf8da253e87d218aed136bee30b1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

| Name | Type | | ----------------- | ----- | | eslint-mdx | Patch | | eslint-plugin-mdx | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codesandbox-ci[bot]]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

[github-actions[bot]]

📊 Package size report   No changes

File	Before	After
Total (Includes all files)	1.2 MB	1.2 MB
Tarball size	116.3 kB	116.3 kB

Unchanged files

| File | Size | | ------------------------------------------------------------------------------------------------------------------------------------------------------------------ | ---------: | | [`.babelrc`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.babelrc) | `35 B` | | [`.changeset/config.json`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.changeset/config.json) | `372 B` | | [`.changeset/README.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.changeset/README.md) | `510 B` | | [`.codesandbox/ci.json`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.codesandbox/ci.json) | `76 B` | | [`.editorconfig`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.editorconfig) | `161 B` | | [`.eslintrc.js`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.eslintrc.js) | `591 B` | | [`.gitattributes`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.gitattributes) | `35 B` | | [`.github/FUNDING.yml`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.github/FUNDING.yml) | `204 B` | | [`.github/workflows/ci.yml`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.github/workflows/ci.yml) | `941 B` | | [`.github/workflows/codeql.yml`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.github/workflows/codeql.yml) | `836 B` | | [`.github/workflows/pkg-size.yml`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.github/workflows/pkg-size.yml) | `496 B` | | [`.github/workflows/release.yml`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.github/workflows/release.yml) | `914 B` | | [`.lintstagedrc.js`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.lintstagedrc.js) | `50 B` | | [`.simple-git-hooks.js`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/.simple-git-hooks.js) | `51 B` | | [`CHANGELOG.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/CHANGELOG.md) | `283 B` | | [`CONTRIBUTING.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/CONTRIBUTING.md) | `931 B` | | [`LICENSE`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/LICENSE) | `1.1 kB` | | [`package.json`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/package.json) | `2.5 kB` | | [`packages/eslint-mdx/CHANGELOG.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/CHANGELOG.md) | `21.8 kB` | | [`packages/eslint-mdx/package.json`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/package.json) | `1.2 kB` | | [`packages/eslint-mdx/README.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/README.md) | `9.8 kB` | | [`packages/eslint-mdx/shim.d.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/shim.d.ts) | `1.4 kB` | | [`packages/eslint-mdx/src/helpers.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/src/helpers.ts) | `6.7 kB` | | [`packages/eslint-mdx/src/index.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/src/index.ts) | `98 B` | | [`packages/eslint-mdx/src/parser.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/src/parser.ts) | `2.3 kB` | | [`packages/eslint-mdx/src/sync.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/src/sync.ts) | `384 B` | | [`packages/eslint-mdx/src/tokens.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/src/tokens.ts) | `6.6 kB` | | [`packages/eslint-mdx/src/types.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/src/types.ts) | `1.2 kB` | | [`packages/eslint-mdx/src/worker.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/src/worker.ts) | `19.6 kB` | | [`packages/eslint-mdx/tsconfig.json`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-mdx/tsconfig.json) | `131 B` | | [`packages/eslint-plugin-mdx/CHANGELOG.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/CHANGELOG.md) | `23.4 kB` | | [`packages/eslint-plugin-mdx/package.json`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/package.json) | `1.0 kB` | | [`packages/eslint-plugin-mdx/README.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/README.md) | `9.8 kB` | | [`packages/eslint-plugin-mdx/src/configs/base.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/configs/base.ts) | `305 B` | | [`packages/eslint-plugin-mdx/src/configs/code-blocks.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/configs/code-blocks.ts) | `1.0 kB` | | [`packages/eslint-plugin-mdx/src/configs/index.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/configs/index.ts) | `345 B` | | [`packages/eslint-plugin-mdx/src/configs/overrides.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/configs/overrides.ts) | `725 B` | | [`packages/eslint-plugin-mdx/src/configs/recommended.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/configs/recommended.ts) | `806 B` | | [`packages/eslint-plugin-mdx/src/helpers.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/helpers.ts) | `620 B` | | [`packages/eslint-plugin-mdx/src/index.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/index.ts) | `105 B` | | [`packages/eslint-plugin-mdx/src/processors/helpers.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/processors/helpers.ts) | `633 B` | | [`packages/eslint-plugin-mdx/src/processors/index.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/processors/index.ts) | `244 B` | | [`packages/eslint-plugin-mdx/src/processors/options.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/processors/options.ts) | `1.8 kB` | | [`packages/eslint-plugin-mdx/src/processors/remark.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/processors/remark.ts) | `1.5 kB` | | [`packages/eslint-plugin-mdx/src/processors/types.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/processors/types.ts) | `241 B` | | [`packages/eslint-plugin-mdx/src/rules/.eslintrc`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/rules/.eslintrc) | `124 B` | | [`packages/eslint-plugin-mdx/src/rules/index.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/rules/index.ts) | `138 B` | | [`packages/eslint-plugin-mdx/src/rules/remark.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/rules/remark.ts) | `3.3 kB` | | [`packages/eslint-plugin-mdx/src/rules/types.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/src/rules/types.ts) | `415 B` | | [`packages/eslint-plugin-mdx/tsconfig.json`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/packages/eslint-plugin-mdx/tsconfig.json) | `131 B` | | [`README.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/README.md) | `9.8 kB` | | [`test/__snapshots__/fixtures.test.ts.snap`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/__snapshots__/fixtures.test.ts.snap) | `23.9 kB` | | [`test/__snapshots__/parser.test.ts.snap`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/__snapshots__/parser.test.ts.snap) | `989.8 kB` | | [`test/fixtures.test.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures.test.ts) | `1.6 kB` | | [`test/fixtures/287.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/287.mdx) | `204 B` | | [`test/fixtures/292.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/292.mdx) | `191 B` | | [`test/fixtures/334.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/334.mdx) | `70 B` | | [`test/fixtures/336.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/336.mdx) | `178 B` | | [`test/fixtures/367.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/367.mdx) | `87 B` | | [`test/fixtures/371.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/371.mdx) | `75 B` | | [`test/fixtures/380.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/380.mdx) | `11.0 kB` | | [`test/fixtures/391.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/391.mdx) | `62 B` | | [`test/fixtures/429.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/429.mdx) | `52 B` | | [`test/fixtures/acorn.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/acorn.mdx) | `860 B` | | [`test/fixtures/adjacent.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/adjacent.mdx) | `50 B` | | [`test/fixtures/async/.remarkrc`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/async/.remarkrc) | `67 B` | | [`test/fixtures/basic.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/basic.mdx) | `405 B` | | [`test/fixtures/basic.tsx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/basic.tsx) | `77 B` | | [`test/fixtures/blank-lines.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/blank-lines.mdx) | `768 B` | | [`test/fixtures/code-blocks.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/code-blocks.md) | `511 B` | | [`test/fixtures/comments.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/comments.mdx) | `162 B` | | [`test/fixtures/details.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/details.mdx) | `881 B` | | [`test/fixtures/dir.mdx/.gitkeep`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/dir.mdx/.gitkeep) | `0 B` | | [`test/fixtures/jsx-in-list.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/jsx-in-list.mdx) | `810 B` | | [`test/fixtures/leading-spaces.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/leading-spaces.mdx) | `42 B` | | [`test/fixtures/markdown.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/markdown.md) | `5 B` | | [`test/fixtures/no-unescaped-entities.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/no-unescaped-entities.mdx) | `99 B` | | [`test/fixtures/no-unused-expressions.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/no-unused-expressions.mdx) | `90 B` | | [`test/fixtures/processor.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/processor.mdx) | `13 B` | | [`test/fixtures/remark.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/remark.md) | `171 B` | | [`test/fixtures/remark.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/remark.mdx) | `169 B` | | [`test/fixtures/style/.remarkrc`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/style/.remarkrc) | `228 B` | | [`test/fixtures/style/nested.md`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/style/nested.md) | `10 B` | | [`test/fixtures/style/plugin1.cjs`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/style/plugin1.cjs) | `26 B` | | [`test/fixtures/style/plugin2.mjs`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/style/plugin2.mjs) | `24 B` | | [`test/fixtures/unicorn.jsx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/unicorn.jsx) | `119 B` | | [`test/fixtures/unicorn.mdx`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/fixtures/unicorn.mdx) | `118 B` | | [`test/helpers.test.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/helpers.test.ts) | `1.5 kB` | | [`test/helpers.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/helpers.ts) | `548 B` | | [`test/parser.test.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/parser.test.ts) | `4.0 kB` | | [`test/remark.test.ts`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/test/remark.test.ts) | `2.8 kB` | | [`tsconfig.base.json`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/tsconfig.base.json) | `235 B` | | [`tsconfig.json`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/tsconfig.json) | `309 B` | | [`tsconfig.lib.json`](https://github.com/mdx-js/eslint-mdx/blob/fix/450/tsconfig.lib.json) | `180 B` |

_{🤖 This report was automatically generated by pkg-size-action}

[codecov-commenter]

Codecov Report

Patch and project coverage have no change.

Comparison is base (b038db9) 100.00% compared to head (a82b674) 100.00%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #458 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 17 17 Lines 199 199 Branches 42 42 ========================================= Hits 199 199 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[wooorm]

Looks good but maybe also test a "void" (boolean) attribute too?

[JounQin]

Looks good but maybe also test a "void" (boolean) attribute too?

See https://github.com/mdx-js/eslint-mdx/blob/master/test/fixtures/429.mdx?plain=1

[wooorm]

That's a different file.

It's fine that that case exists somewhere.

Because the issue title mentioned void (boolean), I personally expected you test them in this PR.

[JounQin]

Done, and found a previous location issue.