Closed JounQin closed 7 months ago
Latest commit: 289ad71ea2a6171d14a7fa4b2af081271f87be40
The changes in this PR will be included in the next version bump.
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
File | Before | After |
---|---|---|
Total (Includes all files) | 1.3 MB |
1.3 MB |
Tarball size | 131.6 kB |
131.6 kB |
🤖 This report was automatically generated by pkg-size-action
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
7ca1ffe
) 100.00% compared to head (289ad71
) 100.00%.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Good to review? @wooorm @ChristianMurphy
@wooorm So we'll have to wait remark-lint
upgrading first?
This is an independent project, so it could update, right? Like all the other projects?
And, other than TypeScript, things still work? Have you tried if it actually works?
@wooorm remark-lint
is not working as expected because the plugins are not upgraded yet.
Can you please clarify what doesn’t work?
In my experience, almost all things do work. Perhaps with a @ts-expect-error
.
https://github.com/mdx-js/eslint-mdx/pull/486#discussion_r1412248980
I'm not so sure what is the root cause, remark-lint or eslint-plugin-markdown, but I've been trying to align the unified version used in eslint-plugin-markdown.
You link to a line of code. I don‘t see what the bug is. Could you please tell me how to reproduce this? What is the actual output, and what is the output you want?
@wooorm
The code blocks fix
properties are removed unexpectedly.
I think it should be related to https://github.com/eslint/eslint-plugin-markdown/issues/218 which would be fixed by https://github.com/eslint/eslint-plugin-markdown/pull/229
I'll use eslint-plugin-markdown@JounQin/eslint-plugin-markdown#feat/bump
to test my fixing PR.
OK, I tried, and it does not work.
I don’t know how to help you.
remark-lint
doesn’t generate fix
properties.
I don’t see that test case using remark-lint
.
@wooorm
mdx/remark
ESLint rule is using remark
processor inside to lint markdown syntaxes.
I think we can merge as-is, and just wait remark-lint
plugins upgrade later.
But why not the other way around? What is the error? It should work.
But, feel free to wait though, maybe say 2 weeks? I don’t have much time to work on oss right now
But why not the other way around? What is the error? It should work.
unified
in remark-lint
are old but I'm using resolutions
to force using the latest unified
packages for all dependencies, I think it's the root cause.
I'm going to merge this PR after upgrading unified-engine
to remove related patch file.
close #480, close #481
The patches are created due to the package manager issue, see also https://github.com/conventional-changelog/commitlint/issues/3642#issuecomment-1678583910