Host the demo - Githubissues

mdx-js / mdx-analyzer

MDX extension for Visual Studio Code

https://marketplace.visualstudio.com/items?itemName=unifiedjs.vscode-mdx

MIT License

346 stars 21 forks source link

Host the demo #261

Closed remcohaszing closed 1 year ago

remcohaszing commented 1 year ago

Initial checklist

[X] I read the support docs
[X] I read the contributing guide
[X] I agree to follow the code of conduct
[X] I searched issues and couldn’t find anything (or linked relevant results below)

Problem

This project has a demo for the Monaco editor integration similar to https://monaco-tailwindcss.js.org, https://monaco-unified.js.org, and https://monaco-yaml.js.org. It would be nice if this demo is hosted somewhere as well.

Solution

The projects mentioned are hosted using Netlify, which is also nice for review environments.

Alternatives

We could also host on Vercel, like https://mdxjs.com. Maybe we want the styling to match https://mdxjs.com and host it on https://monaco.mdxjs.com.

wooorm commented 1 year ago

GH pages is very simple and used in a lot of our places too

remcohaszing commented 1 year ago

I do like GH pages, but it doesn’t support PR review environments, right? This is less of an issue compared to my other Monaco editor related projects, as I have a decent idea how to test it now.

wooorm commented 1 year ago

Not yet, they’re working on it though. Might never happen but it’s a bit promising. Anyway, do we really need that? Presumably the tests check much more than a demo

remcohaszing commented 1 year ago

The GitHub action is ready.

On https://github.com/mdx-js/vscode-mdx/settings/pages, Source needs to be set to GitHub Actions and a custom domain needs to be configured. I don’t have access though.

Personally I’m in favor of using https://monaco.mdxjs.com.

ChristianMurphy commented 1 year ago

On https://github.com/mdx-js/vscode-mdx/settings/pages, Source needs to be set to GitHub Actions

Done

custom domain needs to be configured. I don’t have access though.

This part I don't have access to either

remcohaszing commented 1 year ago

Thanks! The build is now succesful, so that’s good to know.

https://mdx-js.github.io/vscode-mdx/

tippfelher commented 1 year ago

github-actions[bot] commented 1 year ago

Hi team! Could you describe why this has been marked as wontfix?

Thanks, — bb

remcohaszing commented 1 year ago

The Monaco integration was removed in favor of Volar. Use @volar/monaco if you would like to use this with Monaco editor.

github-actions[bot] commented 1 year ago

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.

CapitaineToinon commented 8 months ago

Hey, sorry to revive an old thread but are there examples around on using mdx with monaco via volar, if that's how we're supposed to do it? I've been fiddling around but I'm pretty lost to be honest. I'm trying to setup use monaco to edit MDX stored in my database and I believe this package is where I should be looking at.

remcohaszing commented 8 months ago

You can have a look at @volar/monaco

You should be able to add the language plugin from @mdx-js/language-service for MDX language support and the service plugin for extra functionality, such as syntax error reporting.

websiddu commented 1 month ago

A demo with @volar/monaco and @mdx-js/language-service integration would be greatly apricated and it will be super useful to show case all the featured of mdx-analyzer