mdx-js / mdx-analyzer

MDX extension for Visual Studio Code
https://marketplace.visualstudio.com/items?itemName=unifiedjs.vscode-mdx
MIT License
345 stars 21 forks source link

Extension causes "go to definition" to go to type definition #461

Closed kylemh closed 1 month ago

kylemh commented 3 months ago

Initial checklist

Affected packages and versions

1.8.9 and styled-components@^5

Link to runnable example

No response

Steps to reproduce

Somebody else saw this problem, too: https://github.com/microsoft/vscode/issues/211725

Expected behavior

I should be taken to source definition, especially with "typescript.preferGoToSourceDefinition": true

Actual behavior

I am taken to type definition

Runtime

Node v18

Package manager

pnpm

OS

macOS

Build and bundle tools

Next.js

remcohaszing commented 1 month ago

I’m unable to reproduce. I tried it with both 1.8.9 and 1.8.10. Does the problem still exist for you? If so, please provide a repo with a minimal reproduction.

github-actions[bot] commented 1 month ago

Hi! Thanks for taking the time to contribute! This has been marked by a maintainer as needing more info. It’s not clear yet whether this is an issue. Here are a couple tips:

Thanks, — bb

kylemh commented 1 month ago

The problem existed until I removed the extension! It was happening on a work repo and - once I saw that comment in the TS repo - I attempted the minimum repro that I shared. It's a bit tough for me to share a perfect reproduction because I can't control the Node version of online versions of VS Code. If you did the steps with the correct Node version and told VS Code to use the workspace version of TS (as opposed to the editor version), then I've got no clue! If I re-add, I continue to get the same issue.

github-actions[bot] commented 1 month ago

Hi! This was closed. Team: If this was fixed, please add phase/solved. Otherwise, please add one of the no/* labels.