search

mdx-js / mdx

Markdown for the component era
https://mdxjs.com
MIT License
17.77k stars 1.14k forks source link

Add `remark-mdx-chartjs` to list of plugins #2221

Closed pangelani closed 1 year ago

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
mdx ✅ Ready (Inspect) Visit Preview Jan 13, 2023 at 1:16PM (UTC)
codecov-commenter commented 1 year ago

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage :thumbsup:

Coverage data is based on head (0089e66) compared to base (a17ac87). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2221 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 2064 2064 ========================================= Hits 2064 2064 ``` Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=None)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

wooorm commented 1 year ago

Instead of serializing as JSON and then parsing with acorn (which is slow and prone to breaking), it would be better to use something like https://github.com/remcohaszing/estree-util-value-to-estree!

remcohaszing commented 1 year ago

I agree :100: with @wooorm’s tip. Also you can omit the raw properties and it’s ok to use empty strings as the value of mdxjsEsm nodes as those are unused.

As far as this PR is concerned though, looks good to me :+1:

pangelani commented 1 year ago

Thanks @wooorm and @remcohaszing! I added the suggested improvement to the plugin.