search

mdx-js / mdx

Markdown for the component era
https://mdxjs.com
MIT License
17.77k stars 1.14k forks source link

Fix docs on how to use solid #2300

Closed BeiyanYunyi closed 1 year ago

BeiyanYunyi commented 1 year ago

I found a outdated documentation: it says to use mdx in solid-js, set options.jsxImportSource to 'solid-js', but I tried it and failed.

That's because solid-js have modified its exports. For example, solid-js/jsx-dev-runtime is solid-js/h/jsx-dev-runtime now.

Here's a repro. Clone, modify vite/markdown.ts, change solid/h to solid, then pnpm build to reproduce the problem.

vercel[bot] commented 1 year ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2023 8:52am
codecov-commenter commented 1 year ago

Codecov Report

Patch and project coverage have no change.

Comparison is base (9eb747d) 100.00% compared to head (465a567) 100.00%.

:exclamation: Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2300 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 22 22 Lines 2177 2177 ========================================= Hits 2177 2177 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

wooorm commented 1 year ago

Thanks!