mdx-js / mdx

Markdown for the component era
https://mdxjs.com
MIT License
17.77k stars 1.14k forks source link

Add HMR to example of MDX w/ Vite #2474

Closed dan-lee closed 7 months ago

dan-lee commented 7 months ago

Initial checklist

Description of changes

I have updated the docs for @mdx-js/rollup: I added the suggestion from vite-plugin-reacts include option by adding mdx to the list to enable HMR.

Without it, a full page reload is required, and it took me some time to figure that out. I think one almost always wants that to be enabled.

vercel[bot] commented 7 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 17, 2024 11:53am
codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (908ff45) to head (756374d). Report is 18 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2474 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 23 23 Lines 2693 2709 +16 Branches 2 2 ========================================= + Hits 2693 2709 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wooorm commented 7 months ago

Thanks!