mdx-js / mdx

Markdown for the component era
https://mdxjs.com
MIT License
17.76k stars 1.14k forks source link

Fix size of hero heading in some cases #2481

Closed yamanidev closed 5 months ago

yamanidev commented 6 months ago

Initial checklist

Description

I noticed that the heading of the hero section is spanning in 3 lines, leaving quite some blank in the 2nd line. I thought that condensing it to 2 lines would result in a much better and cleaner layout, hence this PR.

Before: Screenshot from 2024-05-08 14-54-03

After: Screenshot from 2024-05-08 14-54-17

I'd love to hear your thoughts about this.

Changes

I decreased the font size of the heading from 6rem (or 108px) to 5.9rem (or 106.2px).

vercel[bot] commented 6 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2024 2:29pm
wooorm commented 6 months ago

Please share more of what you are seeing and why. I cannot reproduce:

Screenshot 2024-05-08 at 5 37 08 PM
yamanidev commented 6 months ago

I didn't change anything to get the screenshot I shared, that's how it looked on my machine:

image

I just visited the website on Gnome Web (WebKit based browser) and it looks just fine: image

remcohaszing commented 6 months ago

I’m seeing this too on Chrome Linux, but only if the window width is greater than 1215px.

wooorm commented 5 months ago

Thanks! :)