mdx-js / mdx

Markdown for the component era
https://mdxjs.com
MIT License
17.76k stars 1.14k forks source link

Improve scanning and visual structure of example #2511

Closed karlhorky closed 1 month ago

karlhorky commented 4 months ago

Initial checklist

Description of changes

Riffing on 044e8b2a272186be04d16c270f5621718cc8a57e

vercel[bot] commented 4 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
mdx ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 9, 2024 4:45pm
codecov-commenter commented 4 months ago

:warning: Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (908ff45) to head (5c9fcf4). Report is 39 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #2511 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 23 23 Lines 2693 2712 +19 Branches 2 2 ========================================= + Hits 2693 2712 +19 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

wooorm commented 1 month ago

Thanks but no thanks. Appreciate you wanting to help. But I do not agree with several of the proposed changes (there are no default components; console.log is intentional; I prefer actual rendered things here over pseudocode; I don’t think linking to an issue is good here).