search

mdz / python-smarttub

Python API for SmartTub enabled hot tubs
MIT License
6 stars 9 forks source link

J-385 adds a "READY" HeatMode and an "ON" LightMode #39

Closed fowie closed 11 months ago

fowie commented 11 months ago

The J-385 can return back a "READY" value for HeadMode and "ON" value for LightMode. Added these to the Enum. All tests passed.

mdz commented 11 months ago

ON seems self-explanatory -- but what does READY indicate?

fowie commented 11 months ago

It's returning that status when the hot tub is not actively in use. So I'm guessing it indicates the tub is at temp and the heater is not actively in use?

Get Outlook for Androidhttps://aka.ms/AAb9ysg

From: Matt Zimmerman @.> Sent: Saturday, November 4, 2023 8:43:47 AM To: mdz/python-smarttub @.> Cc: Spencer Fowers @.>; Author @.> Subject: Re: [mdz/python-smarttub] J-385 adds a "READY" HeatMode and an "ON" LightMode (PR #39)

ON seems self-explanatory -- but what does READY indicate?

— Reply to this email directly, view it on GitHubhttps://github.com/mdz/python-smarttub/pull/39#issuecomment-1793479602, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AACMTJ3ACGOAVP3P5QV34OLYCZPDHAVCNFSM6AAAAAA65IDWNOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJTGQ3TSNRQGI. You are receiving this because you authored the thread.Message ID: @.***>

mdz commented 11 months ago

There is already a heater: "{OFF/ON}" state which captures whether the heating element is powered up, so that would seem redundant. 🤷