me-box-archive / databox-netdev

Old Dev version Databox OS container manager and dashboard server (do not use)
MIT License
3 stars 6 forks source link

Containerize #19

Closed yousefamar closed 7 years ago

yousefamar commented 7 years ago

Happy new year folks!

Tosh has already begun this in the CM-in-docker branch. I think we should hold off on putting arbiter and CM in the same container until after 0.1 though, since thinking about it introduced more issues that would not necessarily break any appdev APIs, but be important to get right.

If merged, pros are:

But cons are:

The first con could be remedied by adding some sort of auth onto the CM endpoints. For now could just slap Basic Auth onto it and have the user enter a password in the dashboard, or we could just hold off on merging CM and arbiter and use the future account system when we do post-0.1. Are there any other options? Additional thoughts?

Toshbrown commented 7 years ago

Hi yousef,

I didn't think we were putting the CM and the Arbiter into a single container. The CM will run in a container with access to the docker socket, and launch the Arbiter as before.

Running the CM in a container should ease installation.

yousefamar commented 7 years ago

Perfect! Maybe I just misunderstood that part in the meeting. Anyway, just to quote the comment I made on https://github.com/me-box/databox-container-manager/commit/d9f848e2637b843ef6056e15ed0a71f3bcfa7ad5 for prosperity:

Just a quick note in case you run into the same thing, when I tried stuff out on Thursday, I only got it to work with node:argon rather than node:alpine (and ideally we want to use the latter since it's much smaller). I think the issue was when it tried to install node-sass since I believe that's not pure JS (Ruby or something somewhere?). I didn't really investigate much, but if the issue persists, we could always switch that one style sheet to Stylus, which is virtually the same (better even) and pure JS.

If nobody minds, I can take care of that tomorrow, merge into Hypercat, then PR into Hypercat.

Toshbrown commented 7 years ago

This can now be closed once we rename it databox !!

Toshbrown commented 7 years ago

All done!!