me-box / core-export-service

export service for databox platform
MIT License
3 stars 4 forks source link

speak zest to arbiter #30

Closed sevenEng closed 6 years ago

sevenEng commented 6 years ago

as suggested by https://github.com/me-box/databox/issues/267

update export-service to speak zest to arbiter to get the macaroon verification secret

mor1 commented 6 years ago

The contents of zest_client.re look a bit like they're cut'n'paste from Zest-- is that right? If so, oughtn't they be put in a library instead?

sevenEng commented 6 years ago

@mor1 yep, they all come from here: https://github.com/me-box/zestdb/blob/master/test/client.re

i did think about wrapping it up in a library at some point, but thinking deciding what kind of interface to expose is a matter that may needs to sync up with John, and with the refactoring and packaging, which may take us more time and thus push back the new release,

given that the export-service is going to be replaced by a driver soon, and the APIs to arbiter using zest (mainly what this PR is about) have already existed in lib-xx-databox (this may be a call for a lib-ml-databox lib?), so I just grabbed what needed and put it here and made it work

mor1 commented 6 years ago

ah ok, fair enough. On Wed, 18 Jul 2018 at 17:34, Qi LI notifications@github.com wrote:

@mor1 yep, they all come from here: https://github.com/me-box/zestdb/blob/master/test/client.re

i did think about wrapping it up in a library at some point, but thinking deciding what kind of interface to expose is a matter that may needs to sync up with John, and with the refactoring and packaging, which may take us more time and thus push back the new release,

given that the export-service is going to be replaced by a driver soon, and the APIs to arbiter using zest (mainly what this PR is about) have already existed in lib-xx-databox, so I just grabbed what needed and put it here and made it work

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.

-- Richard Mortier mort@cantab.net