me-box / databox

Databox container manager and dashboard server
MIT License
94 stars 25 forks source link

Don't use env vars to pass secrets #3

Closed Toshbrown closed 7 years ago

Toshbrown commented 7 years ago

Passing the arbiter token and https certs via Env vars is not best practice.

Docker 1.13 has support for secrets management see, Manage sensitive data with Docker secrets but this only works in swarm mode (I'm not sure how this will effect Databox).

Another option could be to use something like keywhiz or sneaker or to roll our own into the arbiter.

yousefamar commented 7 years ago

Seems like we've finally reached that bridge! Dockerode wraps working with secrets through the Docker Remote API too. I think it might be worth investigating Docker swarm mode in general, especially since it might come in handy in other areas (previous discussions with @mor1 regarding https://docs.docker.com/engine/swarm/how-swarm-mode-works/pki/ and managing certs). Perhaps @avsm might have some insights regarding possible ways to use this in our context.

avsm commented 7 years ago

Could just run a databox as a swarm-of-one as well.

Toshbrown commented 7 years ago

swarm-of-one implemented