ricorandom
commented
1 year ago Hi Mi Yu,
Pausable https://docs.openzeppelin.com/contracts/4.x/api/security#Pausable works, i'd be happy to use that instead, do you want me to make that amendment?
On Wed, May 24, 2023 at 8:06 PM Michael Yu @.***> wrote:
@.**** commented on this pull request.
In contracts/ERC721MOperatorFilterer.sol https://github.com/magicoss/erc721m/pull/87#discussion_r1204645529:
@@ -2,10 +2,14 @@
pragma solidity ^0.8.4;
+import @.***/contracts/access/Ownable.sol"; + import "./ERC721M.sol"; import "./OperatorFilter/DefaultOperatorFilterer.sol";
contract ERC721MOperatorFilterer is ERC721M, DefaultOperatorFilterer {
rather than modifying ERC721MOperatorFilterer, recommend creating a new variant like ERC721MOperatorFiltererPausable which extends ERC721MOperatorFilterer
Also thoughts on using Pausable https://docs.openzeppelin.com/contracts/4.x/api/security#Pausable?
— Reply to this email directly, view it on GitHub https://github.com/magicoss/erc721m/pull/87#pullrequestreview-1442578068, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5E5MOEJSYVPAXFWXJ7QYY3XHZL4NANCNFSM6AAAAAAYNRLECM . You are receiving this because you authored the thread.Message ID: @.***>
Added the pause feature and the import for the ownable contract.