ONFT POC - Githubissues

me-foundation / magicdrop

MagicDrop is a collection of EVM minting protocols that enable the multi stage minting, per stage WL management, per stage supply limit, and crossmint support.

MIT License

54 stars 37 forks source link

ONFT POC #92

Closed channing-magiceden closed 1 year ago

channing-magiceden commented 1 year ago

Add LayerZero ONFT support (lite version)
- codes are copied from LZ branch: https://github.com/LayerZero-Labs/solidity-examples/tree/LzAppLite
Add ERC721MLite to make the contract size within 24k limit
Add ERC721Onft for ONFT minting

Note: we cannot fully test LayerZero code. I think we need an audit before we do large scale launches.

Contract size:

Tests:

Minting contract on Goerli: https://goerli.etherscan.io/address/0x34B786037E7a8CD4b4b1790Ce5F72787FEd604a5
Sibling contract on Mumbai: https://mumbai.polygonscan.com/address/0x15f963ae86e562535a1546f9417b604e29fe78f6
Verified tokens minted on Goerli was successfully bridged to mumbai:

Follow-up:

Adding Operator Filterer - this is necessary to use these contracts for EVM launches
Removing things from IERC721M interface that are unnecessary for ERC721MLite, will help with cutting down the contract sizes
Adding comments above each "Lite" contract definition for what makes them "Lite" - so future readers can understand quickly what makes them different from the default versions

channing-magiceden commented 1 year ago

Stamping with some ideas for things that can be addressed in a later PR:

Adding Operator Filterer - this is necessary to use these contracts for EVM launches

Removing things from IERC721M interface that are unnecessary for ERC721MLite, will help with cutting down the contract sizes

Adding comments above each "Lite" contract definition for what makes them "Lite" - so future readers can understand quickly what makes them different from the default versions

Thanks. Added into the PR description.