me-no-dev / ESPAsyncTCP

Async TCP Library for ESP8266
GNU Lesser General Public License v3.0
758 stars 394 forks source link

When setting #define ASYNC_TCP_SSL_ENABLED 1 build fails #131

Closed jeroenst closed 4 years ago

jeroenst commented 5 years ago

When I want to use the SSL feature, and enable #define ASYNC_TCP_SSL_ENABLED 1 in async_config.h I get the following build error:

/home/jeroen/Arduino/libraries/ESPAsyncTCP/src/ESPAsyncTCP.cpp: In member function 'err_t AsyncServer::_poll(tcp_pcb)': /home/jeroen/Arduino/libraries/ESPAsyncTCP/src/ESPAsyncTCP.cpp:1324:31: error: no matching function for call to 'AsyncClient::_recv(tcp_pcb&, pbuf&, int)' c->_recv(pcb, p->pb, 0); ^ /home/jeroen/Arduino/libraries/ESPAsyncTCP/src/ESPAsyncTCP.cpp:1324:31: note: candidate is: /home/jeroen/Arduino/libraries/ESPAsyncTCP/src/ESPAsyncTCP.cpp:565:6: note: void AsyncClient::_recv(std::shared_ptr&, tcp_pcb, pbuf, err_t) void AsyncClient::_recv(std::shared_ptr& errorTracker, tcp_pcb pcb, pbuf* pb, err_t err) { ^ /home/jeroen/Arduino/libraries/ESPAsyncTCP/src/ESPAsyncTCP.cpp:565:6: note: candidate expects 4 arguments, 3 provided

mhightower83 commented 5 years ago

@jeroenst - Sorry, I missed that build option in my original testing of my now merged PR. This new PR https://github.com/me-no-dev/ESPAsyncTCP/pull/129#issue-326553487 should resolve your problem plus one more corner case that I found. If you download the four files that changed and recompile, it should work. Please post back your result so others will know if it worked.

stale[bot] commented 4 years ago

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

shprota commented 4 years ago

The fix has worked for me. Please close the issue.

stale[bot] commented 4 years ago

[STALE_CLR] This issue has been removed from the stale queue. Please ensure activity to keep it openin the future.

stale[bot] commented 4 years ago

[STALE_SET] This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

[STALE_DEL] This stale issue has been automatically closed. Thank you for your contributions.