search

me-no-dev / arduino-esp32fs-plugin

Arduino plugin for uploading files to ESP32 file system
GNU General Public License v2.0
544 stars 144 forks source link

Added LittleFS and FatFS choice on drop-down #23

Closed lorol closed 3 years ago

lorol commented 4 years ago

If you ever want to have this hack to add LittleFS and FatFS choice to the original tool made only for SPIFFS ... please consider this PR

lorol commented 3 years ago

Added FatFS,, mk...fs binaries and modified Update lib to work with all three filesystems through serial port and ota.

lbernstone commented 3 years ago

This either needs to be merged, or forked into its own project, as there are a number of issues being reported that won't apply to @me-no-dev's version.

lorol commented 3 years ago

@lbernstone I really added stuff after that request to resolve my needs, and built it in a dummy way w/o any planned and tested approach by different hosts and so on. If you'd like to re-develop it in a proper way - please do it. Especially FFat part - it is based on your ideas and the counterpart mk binaries can be linked from original repositories.

Otherwise, I don't know what to do with merging to the original. It looks like it is mergeable.

I guess the merge itself can be done only by the authorized people?

lbernstone commented 3 years ago

Can you separate out the bits that are absolutely needed to support the esp32s2 and submit those as a separate PR? That is what really needs to make it back upstream.

lorol commented 3 years ago

@lbernstone In this case it is best to ask @zouffin the author of this addition to PR directly at upstream repository. See here how the story started: https://github.com/lorol/arduino-esp32fs-plugin/pull/2 And I do not have s2 device to test.

lorol commented 3 years ago

Agree with @lbernstone for more conservative PR approach with fewer changes at a time, starting by most important ones. Maybe later will PR again. For now, I continue with the fork here: https://github.com/lorol/arduino-esp32fs-plugin