me-no-dev / arduino-esp32fs-plugin

Arduino plugin for uploading files to ESP32 file system
GNU General Public License v2.0
544 stars 144 forks source link

Plugin does not use custom partitions.csv #33

Open dl9rdz opened 2 years ago

dl9rdz commented 2 years ago

Since https://github.com/espressif/arduino-esp32/pull/3328, there can be a custom partitions.csv file in a sketch.

The Arduino ESP32 filesystem uploader plugin ignores such custom partitions.csv. Thus it does not use the correct size and location for the SPIFFS for Arduino sketches that use a custom partitions.csv file.

robertgregor commented 1 year ago

I am also looking into this thing. @dl9rdz you have already the working jar, which is using it? Can you send it to us? Seems, me-no-dev didn't merged your code yet :)

dl9rdz commented 1 year ago

It should be here: https://github.com/dl9rdz/arduino-esp32fs-plugin/releases/tag/1.0mod

robertgregor commented 1 year ago

Hi, thanks a lot. I have tried to do modification in the source code and tried to compile it with the javac, but I don't know, which jars from arduino, I have to include to the classpath. Can you add the javac compile command here? Or are you using some arduino tool to compile the java file? Thanks!!!

dl9rdz commented 1 year ago

Just running "make.sh" works for me.

javac needs pde.jar, arduino-core.jar, and commons-codec-1.7.jar from arduino

twinsvision commented 9 months ago

Hi, with this esp32fs plugin I get the following error which was not the case with the unpatched version: "A fatal error occurred: This chip is ESP32-S3 not ESP32. Wrong --chip argument?" By the way, the correct board is selected in Arduino menu...

The actual output is:

[SPIFFS] upload : /var/folders/by/xfznghr974sb5_mlknfgkcjm0000gn/T/arduino_build_393891/ui.spiffs.bin [SPIFFS] address: 16842752 [SPIFFS] port : /dev/cu.usbserial-1120 [SPIFFS] speed : 921600 [SPIFFS] mode : dout [SPIFFS] freq : 80m

esptool.py v4.5.1 Serial port /dev/cu.usbserial-1120 Connecting...

A fatal error occurred: This chip is ESP32-S3 not ESP32. Wrong --chip argument? SPIFFS Upload failed!

dl9rdz commented 9 months ago

I upgraded my patched version to 1.1, this should resolve that problem https://github.com/dl9rdz/arduino-esp32fs-plugin/releases/tag/1.1mod

twinsvision commented 9 months ago

@dl9rdz Great job! Working like a charm now, many thanks :)