search

me0wster / javamelody

Automatically exported from code.google.com/p/javamelody
0 stars 0 forks source link

Provide an option for disabling internal gzipping #237

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Whenever you integrate Javamelody with a framework or a front-end node that 
handles gzipping, you run into an issue with Javamelody's own gzipping. You've 
handled these issues on case-by-case basis, like checking whether 
HttpServletReponse class names starts with "Compression" for Jenkins (see 
https://issues.jenkins-ci.org/browse/JENKINS-14050 and 
https://code.google.com/p/javamelody/source/browse/trunk/javamelody-core/src/mai
n/java/net/bull/javamelody/MonitoringController.java?spec=svn2865&r=2865) but 
this is not sustainable, you can't fix it for all apps and libraries 
separately. The simplest solution would be to provide a configurable option to 
turn it off.

Original issue reported on code.google.com by kalle.o....@gmail.com on 16 Jul 2012 at 3:21

GoogleCodeExporter commented 9 years ago 
This is quite true. And this was proven by the fact that the revision given 
above was finally not enough to fix the Jenkins issue.

And so this was changed and a new parameter was added to be used by the Jenkins 
plugin.
See the revision 2900.
https://code.google.com/p/javamelody/source/detail?r=2900

This change with the parameter was released in 1.39.0 on June, 20.
This parameter is not yet documented but it's name is 
"gzip-compression-disabled" and you can use it as the other optional 
parameters, in web.xml or with a system property:
https://code.google.com/p/javamelody/wiki/UserGuide#6._Optional_parameters

Since it is already released, I suppose that it is only needed to add it in the 
user guide, and this will be fixed?

Original comment by evernat@free.fr on 16 Jul 2012 at 9:42

GoogleCodeExporter commented 9 years ago

Original comment by evernat@free.fr on 16 Jul 2012 at 9:42

GoogleCodeExporter commented 9 years ago 
Perfect - I already updated to 1.39.0 but didn't see any issue for gzip or 
anything in the documentation, so I didn't bother reading the source. Yes, 
thank you, adding it in the user guide is then all that's left. And thanks for 
a great monitoring tool!

Original comment by kalle.o....@gmail.com on 16 Jul 2012 at 3:17

GoogleCodeExporter commented 9 years ago 
And this is now documented near the end of the "Optional parameters" chapter of 
the user guide:
http://code.google.com/p/javamelody/wiki/UserGuide#6._Optional_parameters

Original comment by evernat@free.fr on 25 Jul 2012 at 4:20