search

me0wster / javamelody

Automatically exported from code.google.com/p/javamelody
0 stars 0 forks source link

spring config files may trigger internet access #243

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
In spring config files supplied by javamelody, xsd schemas refer to 
version-speicifc schemas.

For example
https://javamelody.googlecode.com/svn/tags/javamelody-core-1.39.0/javamelody-cor
e/src/main/resources/net/bull/javamelody/monitoring-spring.xml refers to 
spring-beans-2.5.xsd

https://javamelody.googlecode.com/svn/tags/javamelody-core-1.39.0/javamelody-cor
e/src/main/resources/net/bull/javamelody/monitoring-spring-aspectj.xml refers 
to spring-beans-3.0.xsd

If these config files are used in a spring 2.0 or spring 2.5 (for 
spring-aspectj.xml) setup, then that version of spring wouldn't recognize 
javamelody-supplied versions. That can trigger a internet access, which may be 
undesirable or problematic in certain deployment environments.

If possible, the spring config files should be changed to refer to a generic 
xsd schemas. i.e. "spring-beans.xsd", not "spring-beans-3.0.xsd"

Original issue reported on code.google.com by maxxe...@gmail.com on 10 Aug 2012 at 11:07

GoogleCodeExporter commented 9 years ago 
In monitoring-spring.xml, monitoring-spring-datasource.xml and in 
monitoring-spring-aspectj.xml, I have changed from
http://www.springframework.org/schema/beans/spring-beans-2.5.xsd
to
http://www.springframework.org/schema/beans/spring-beans.xsd
and other similar URLs.
This should fix the issue.
It is committed in trunk, revision 2989, and ready for the next release (1.40).

I have made a new build from the trunk, including the fix, and it is available 
at:
http://javamelody.googlecode.com/files/javamelody-20120811.jar

Original comment by evernat@free.fr on 11 Aug 2012 at 1:28