search

me0wster / javamelody

Automatically exported from code.google.com/p/javamelody
0 stars 0 forks source link

JsfActionListener Sends Two Requests When Javamelody is Disabled #248

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Configure a web application with Javamelody's JSFActionListener
2. Disable Javamelody by setting the "javamelody.disabled=true" SystemProperty 
3. Submit any request in the web application

What is the expected output? What do you see instead?

Any requests passing through the Listener are duplicated. This is caused by the 
JSFActionListener.processAction(..) propagating the request twice to 
"delegateActionListener" when the DISABLED flag is set. The attached patch 
should fix this, although I couldn't test & verify this at the moment.

What version of the product are you using? On what application server, JDK,
operating system?

I ran into this issue using JBoss 6.0.0.Final with a JSF 2 application (using 
RichFaces), with Oracle's JVM 1.6.0_32 on a Ubuntu Linux machine.

Original issue reported on code.google.com by b.her...@gmail.com on 4 Sep 2012 at 12:20

Attachments:

GoogleCodeExporter commented 9 years ago 
You are absolutely right.
The patch is included in trunk, revision 3050.

I have made a new build from the trunk including the fix and it is available at:
http://javamelody.googlecode.com/files/javamelody-20120909.jar

Original comment by evernat@free.fr on 9 Sep 2012 at 4:49