Peer Review

[Iandris]

Design/Code Review 1

Project: BWS Intranet

Developer: Sue

Reviewer: Mike Young

Category	Criteria	Rating/Comments
Problem Statement	Does it exist? yes	reviewer rating/comments go here
Does the problem statement accurately describe project purpose?	yes
Is the problem statement professional? Think of prospective employers viewing this as part of the developer's portfolio.	yes
What is good?		each component is defined well
What could be improved?		perhaps look to limit how much you are trying to do, this seems like a lot of pieces.
Design Documentation	Does it exist?	yes
Is the navigation/flow through the application logical and easy to use?	no	I had a hard time following the flow from task to task given the mockups/documentation provided
Is the order in which the fields are displayed and form fields entered logical and easy to use?	NA	I didn't see any forms
What data is missing?		the visual documents (mock ups) are only in print form
Is there data that is not used?	no
What is good?		the high level overview gives a good idea of what will happen
What could be improved?		as you noted, the mock ups were only in print
Data model	Does it exist?	yes but only in a markdown file
Is everything on the screens represented in the model?		difficult to say given the lack of mockups/forms
Does the model represent good database design?	no	not sure since relationships are not identifiable in this format
What is good?		a few of the tables look like they have relevant attributes
What could be better?		there were no relationships represented in the model, hard to tell how each table relates to others.
Additional design documents
Application structure in IntelliJ	Does it exist?	no
Is the structure correct for a Maven project?	NA
Are packages and classs appropriately named?	NA
Other comments/notes?
JSPs	Do they exist?	no
Is templating used (for example, header.jsp, footer.jsp, etc.)?	NA
Is there business logic mixed in the JSPs?	NA
CSS?	no
Other comments/notes?
Entities/DAOs/Controllers	Do they exist?	no
Java code quality	Are methods single-purpose?	NA
Are classes appropriately-sized classes (no monster classes)?	NA
Are the same lines of code repeated at all?	NA
Do any classes perform very similar functions that could be candidates for super/subclass relationships?	NA
Are any values hard-coded that should be in a properties file?	NA
Are variable names descriptive?	NA
Are there many branches or loops that could be simplified or broken up into smaller methods?	NA
Do the DAOs use Hibernate? No hard-coded sql!	NA
Other comments/notes?
Logging	Has log4J been added?	NA
Are there logging statements in the code?	NA
Are appropriate logging levels used? Info, debug, error, for example.	NA
Are there any System.out.printlns in the code?	NA
Other comments/notes?	NA
Unit Tests	Do they exist?	no
Do the tests pass?	no
What is the current code coverage?	NA
Is each test truly a unit test or are they functional tests?	NA
Other comments/notes?	NA
Web Service/API integration	Has a web service/api been selected?	no
What web services/apis might work well with this application?		I think your weather idea would be a good implementation of an api you can use
Independent research topic	Has a topic been selected?	no
What topic/s might fit well in this application?		bootstrap/css or jquery