search

meadsteve / MonoSnag

🐛 Monolog handler for bugsnag.
MIT License
20 stars 14 forks source link

Update severityMapping #4

Closed mtibben closed 8 years ago

mtibben commented 8 years ago

The latest bugsnag client only allows error, warning and info. See https://github.com/bugsnag/bugsnag-php/blob/master/src/Bugsnag/Error.php#L5-L9

Trying to set "fatal" results in

Bugsnag Warning: Tried to set error severity to fatal which is not allowed.
meadsteve commented 8 years ago

@mtibben Thanks for this. It looks like fatal got removed in version 2.2.5 of bugsnag: https://github.com/bugsnag/bugsnag-php/commit/b35116acf3a5d760afafe11ec3214ec3983dedfa

I'll merge your change in to master. Though I'm currently not sure whether this constitutes a breaking change or not to MonoSnag.

mtibben commented 8 years ago

No it's not a breaking change. If you're following semver rules, this should only require a patch number increment to the version - it's a backwards compatible bugfix (the bug being caused by upstream breaking change)

meadsteve commented 8 years ago

@mtibben I'm inclined to agree with you. However the other option I'm weighing up is:

Release a patch version that won't allow installation of 2.2.5 of bugsnag. Then include your changes in a new major version.

My concern is that only release a patch version will collate two levels of errors together without any users of MonoSnag being made aware of this. But as bugsnag have already dropped the fatal maybe it's not much of an issue.

mtibben commented 8 years ago

:+1: Fair enough. Either way sounds good