search

meadsteve / lagom

📦 Autowiring dependency injection container for python 3
https://lagom-di.readthedocs.io/en/latest/
MIT License
286 stars 15 forks source link

Raise an exception if an Awaitable is omitted in a type hint (Sourcery refactored) #210

Closed sourcery-ai[bot] closed 2 years ago

sourcery-ai[bot] commented 2 years ago

Pull Request #207 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will re-run and update (force-push) this Pull Request with new refactorings as necessary. If Sourcery finds no refactorings at any point, this Pull Request will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the better-async-experience branch, then run:

git fetch origin sourcery/better-async-experience
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

❌  Merging this PR will decrease code quality in the affected files by 0.20%.

Quality metrics Before After Change
Complexity 1.56 ⭐ 1.54 ⭐ -0.02 👍
Method Length 44.12 ⭐ 43.90 ⭐ -0.22 👍
Working memory 3.34 ⭐ 3.41 ⭐ 0.07 👎
Quality 85.24% ⭐ 85.04% ⭐ -0.20% 👎
Other metrics Before After Change
Lines 656 649 -7
Changed files Quality Before Quality After Quality Change
lagom/container.py 81.62% ⭐ 81.38% ⭐ -0.24% 👎
lagom/util/reflection.py 85.77% ⭐ 84.98% ⭐ -0.79% 👎
tests/test_dep_definition_functions.py 92.25% ⭐ 92.32% ⭐ 0.07% 👍

Here are some functions in these files that still need a tune-up:

File Function Complexity Length Working Memory Quality Recommendation
lagom/container.py _infer_dependencies 3 ⭐ 96 🙂 11 😞 64.67% 🙂 Extract out complex expressions
lagom/container.py partial 1 ⭐ 137 😞 70.43% 🙂 Try splitting into smaller methods

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!