meadsteve / lagom

📦 Autowiring dependency injection container for python 3
https://lagom-di.readthedocs.io/en/latest/
MIT License
278 stars 15 forks source link

Add dependency stack when formatting UnresolvableType #235

Closed bastienexertier closed 1 year ago

bastienexertier commented 1 year ago

This will help users identify which dependency is unresolvable when a UnresolvableType error is thrown.

meadsteve commented 1 year ago

Thanks @bastienexertier this looks really useful 👍 There's an error when running against the compiled version of the code. I'm a bit pushed for time today but I should be able to take a look later and offer some suggestions.

bastienexertier commented 1 year ago

Sounds good!

meadsteve commented 1 year ago

Since the only test was some of the message missing when running on the compiled code I've just skipped the test for now. It can always be worked on in the future to improve it. This looks great 👍 so I'll merge it and release it soon. Thanks @bastienexertier for spending the time on this.

meadsteve commented 1 year ago

Released as 2.4.0 https://github.com/meadsteve/lagom/releases/tag/2.4.0