meafmira / bs-axios

Bucklescript bindings for axios
71 stars 23 forks source link

Axios dependency #25

Open Coobaha opened 4 years ago

Coobaha commented 4 years ago

hi @meafmira,

I think axios should be moved to peerDependencies. Especially since it is not used in generated files

redacted output of yarn why axios

yarn why v1.21.1
[1/4] 🤔  Why do we have the module "axios"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "axios@0.19.1"
info Has been hoisted to "axios"
info Reasons this module exists
   - "workspace-aggregator-43088911-9698-4e6f-aaa9-6d34f43842d4" depends on it
info Disk size without dependencies: "488KB"
info Disk size with unique dependencies: "656KB"
info Disk size with transitive dependencies: "804KB"
info Number of shared dependencies: 3
=> Found "bs-axios#axios@0.18.1"
info This module exists because "bs-axios" depends on it.
info Disk size without dependencies: "412KB"
info Disk size with unique dependencies: "604KB"
info Disk size with transitive dependencies: "752KB"
info Number of shared dependencies: 4
✨  Done in 0.95s.
hoijui commented 4 months ago

@meafmira , could you maybe add additional owners to this repo, so we have a chance to maintain this? There are projects that depend on this, and because of old deps of this project, those projects can not be maintained either.

I recommend adding the people of the issues:

optionally also me (@hoijui), though I am not a node/JS dev.

really, there is nothing to be lost, because as it is now, it is unusable (in modern software).

have a good day!

meafmira commented 4 months ago

Hey @hoijui 👋 Done