meafmira / bs-axios

Bucklescript bindings for axios
71 stars 23 forks source link

Axios dependency change #51

Closed flyjwayur closed 2 years ago

flyjwayur commented 2 years ago

Hi :) Thank you so much for writing and sharing axios bindings 🌟

Perhaps, could moving axios to be in peerDependencies and devDependencies be an option to consider to solve the below case? 😄
In some cases, having axios as a dependency seems to lead to have duplicated dependencies and may lead to inconsistencies between installed axios.

myproject@1.1.2
├── axios@0.22.0
└─┬ bs-axios@0.0.43
  └── axios@0.21.4

The axios v0.22.0 seems to be the last version without breaking changes, so the version >= 0.21.1 <= 0.22.0 was provided for axios.

I am a Reasonml beginner and it's the first time to propose something. Please don't hesitate to let me know if I've missed out anything 🙏