How many unit test did you write for this pull request?
0
Write a reason if none (e.g just fixed a typo):
Just adding additional imports.
Please add a description for your pull request:
When building a ngrx version with the latest typecsript/angular/etc I received quite a few compile errors in the format of:
Public property {foo} of exported class has or is using name {bar} from external module {baz} but cannot be named.
The crux of it came down to definition files not being able to build for things like import { map } from 'rxjs/operators/map without also importing {Observable} from 'rxjs/Observable.
The reason for the change from exporting an object to a namespace for auth actions was a similar type of error:
Public property '{foo}$' of exported class has or is using name '(Anonymous class)' from external module in effects/auth.ts.
What type of pull request are you creating?
How many unit test did you write for this pull request?
Write a reason if none (e.g just fixed a typo): Just adding additional imports.
Please add a description for your pull request:
When building a ngrx version with the latest typecsript/angular/etc I received quite a few compile errors in the format of:
Public property {foo} of exported class has or is using name {bar} from external module {baz} but cannot be named.The crux of it came down to definition files not being able to build for things like
import { map } from 'rxjs/operators/mapwithout also importing{Observable} from 'rxjs/Observable.The reason for the change from exporting an object to a namespace for auth actions was a similar type of error:
Public property '{foo}$' of exported class has or is using name '(Anonymous class)' from external moduleineffects/auth.ts.