search

mean-expert-official / loopback-sdk-builder

Tool for auto-generating Software Development Kits (SDKs) for LoopBack
Other
399 stars 178 forks source link

Encode plus signs in search params of requests #572

Closed pbouda closed 6 years ago

pbouda commented 6 years ago

What type of pull request are you creating?

How many unit test did you write for this pull request?

I do not really know how to test this at the moment. Maybe someone can give me a hint where to start? Then I will update the PR with tests.

Please add a description for your pull request:

This fix encodes plus signs in the Angular SDK when they are sent as search params. Currently, Angular does not encode plus signs, they are received as empty space on the Loopback side. I applied the fix that is described here:

https://github.com/angular/angular/issues/11058#issuecomment-292457108

pbouda commented 6 years ago

Sorry, will recreate with development branch.