search

mean-expert-official / loopback-sdk-builder

Tool for auto-generating Software Development Kits (SDKs) for LoopBack
Other
399 stars 178 forks source link

Angular 6, RxJS 6 support #594

Closed Nosfistis closed 6 years ago

Nosfistis commented 6 years ago

What type of issue are you creating?

What version of this module are you using?

2.2.7

Please add a description for your issue:

Angular 6 has made RxJS 6 minimum dependency, which changes a lot in imports. Currently it is not possible to use the generator with 6.

For example, importing import { Observable } from 'rxjs/Observable' is no longer supported.

A solution would also be to require rxjs-compat so that the dependencies are resolved for now.

codephobia commented 6 years ago

I have been looking into this since I would also like to use Angular 6 along side loopback. It looks like Nativescript does not yet support Angular 6, but will support it end of May / early June (Nativescript 4.1). Waiting for this support is likely ideal, but then should just have to go through the update checklist here in the angular portion and on the corresponding tests: https://update.angular.io/.

Hoping that someone with more experience than myself is already eyeing up a pull request for this.

PhilippeCorreges commented 6 years ago

Hello, Yup, just facing the same here. Would be very nice to have :)

Thanks

Nosfistis commented 6 years ago

Created a PR for this. I have to mention that I could not get the tests running either before or after the changes (missing endpoints).