search

mean-expert-official / loopback-sdk-builder

Tool for auto-generating Software Development Kits (SDKs) for LoopBack
Other
399 stars 178 forks source link

fix(sdk): RxJS imports comply to v6 #597

Closed Nosfistis closed 6 years ago

Nosfistis commented 6 years ago

All RxJS imports follow the new v6+ importing scheme for tree-shaking and compatibility with Angular v6.

Fixes #594

What type of pull request are you creating?

How many unit test did you write for this pull request?

None

Write a reason if none (e.g just fixed a typo): No functionality added

Please add a description for your pull request:

Migrates all rxjs imports to tree-shakable (importing from rxjs and rxjs/operators only) to comply with RxJS 6, Angular 6.

It is still compatible with the previous required RxJS version (5.5.9).

PhilippeCorreges commented 6 years ago

Thanks @jonathan-casarrubias for this dev.

jonathan-casarrubias commented 6 years ago

Sure no problem, actually we must thanks @Miced for sending the patch, I'm just the messenger :)

Cheers, Jon

PhilippeCorreges commented 6 years ago

Should we just update the package and generate the new sdk with the package updated ?

jonathan-casarrubias commented 6 years ago

Yeah I assume that, if you have the flag to wipe the sdk directory, then just do that.. Install and rebuild.

If you have it disabled, then you might need to manually remove the sdk directory for now.

Cheers Jon