mean-expert-official / loopback-sdk-builder

Tool for auto-generating Software Development Kits (SDKs) for LoopBack
Other
399 stars 178 forks source link

fixed missing type information on related models #622

Open joschne opened 5 years ago

joschne commented 5 years ago

What type of pull request are you creating?

How many unit test did you write for this pull request?

zero. small fix that runs without any problems on my big project.

Please add a description for your pull request:

Issue Related models will not be typed (i.e. get the type any or any[]) if they do not appear in a scope method (like `getrelated_model"). This leads to a lot of missing type information if you have a clean rest api, where you only expose a few remote methods but not the whole bunch of methods exposed by default.

Solution This Pull Request adds the type information about the related model to the model description.

joschne commented 5 years ago

Additionally I added a '?' to optional class properties in order to support this feature introduced with TypeScript 2