mean-expert-official / loopback-sdk-builder

Tool for auto-generating Software Development Kits (SDKs) for LoopBack
Other
399 stars 178 forks source link

Doesn't work on Angular 10 #656

Open vanderdill opened 4 years ago

vanderdill commented 4 years ago

What type of issue are you creating?

What version of this module are you using?

Please add a description for your issue:

Angular 10 now requires template on ModuleWithProviders class. So, the following line on index.ts: }): ModuleWithProviders {

showld be: }): ModuleWithProviders<SDKBrowserModule> {

Schinkentanz commented 3 years ago

I've added a fix & opened a pull req: https://github.com/mean-expert-official/loopback-sdk-builder/pull/657

vanderdill commented 3 years ago

I've added a fix & opened a pull req: #657

Unfortunately the author(s) doesn't seem to keep mantaining the project. There are pull request opened from 2018 :/. I've made my own fork to fix this.

Schinkentanz commented 3 years ago

Dito ;) but at least i tried

psomby commented 3 years ago

Same here, would be nice that it gets fixed but I guess that won't happen..

rollwhistler commented 3 years ago

I've added a fix & opened a pull req: #657

Unfortunately the author(s) doesn't seem to keep mantaining the project. There are pull request opened from 2018 :/. I've made my own fork to fix this.

Can you share that by any chance? :-) @vanderdill

Schinkentanz commented 3 years ago

@rollwhistler You can install dependencies by defining them by their github.com path. That way you could use my fork or fork it yourself 🙂 👍

{
  "devDependencies": {
    "@mean-expert/loopback-sdk-builder": "Schinkentanz/loopback-sdk-builder#0e05fb6"
  }
}
rollwhistler commented 3 years ago

Thanks @Schinkentanz, I cannot just fork it myself since I would need to implement the fixes, which I don't know how to right now :-), I was hoping for a working updated version of this.

Does yours work with Angular 10? I'll give it a try, thank you!

Schinkentanz commented 3 years ago

😄 Yes, I used this fix with v10 and currently with v11.2.2 👍

rollwhistler commented 3 years ago

src/app/shared/sdk/services/custom/logger.service.ts:51:13 - error TS2339: Property 'profileEnd' does not exist on type 'Console'.

Will this go away if I update to angular 11? :-D.

Ok, it was my fault, I got old type definitons on my package.json, I updated to "@types/node": "^10.17.55" and now is fine.

jbratu commented 3 years ago

Look at Loopback 4 documentation Building an Angular Application from OpenAPI Specification which shows how to generate an OpenAPI spec JSON file and then generate models for the Angular application.