search

meanbee / magento2-royalmail

[No Longer Supported] A Royal Mail shipping integration for Magento 2.
Open Software License 3.0
5 stars 4 forks source link

Addes fixes for ISSUE #12 #14

Open atishgoswami opened 7 years ago

atishgoswami commented 7 years ago
bobbyshaw commented 7 years ago

Thanks for experimenting with this. Like @munawar99 mentioned https://github.com/meanbee/magento2-royalmail/issues/12#issuecomment-306049891 I think that there's a little more that needs to be done here.

I'm unsure because I experimented myself but didn't get it working but there are a couple of lines in the setup file that are referring to the src directory that likely need to be updated: https://github.com/meanbee/magento2-royalmail/blob/master/bin/setup.sh#L11

Are you sure about that composer auth line change? That errors in travis: 

[RuntimeException]                           
  http-basic.repo.magento.com is not defined.
atishgoswami commented 7 years ago

Hi @bobbyshaw,

I have checked the command on my local machine and works fine.

composer config --global --auth http-basic.repo.magento.com 14c4b06b824ec593239362517f538b29 5f4dcc3b5aa765d61d8327deb882cf99

Seems like the environment variables $COMPOSER_MAGENTO_USERNAME $COMPOSER_MAGENTO_PASSWORD not proper configured with TRAVIS. So whenever the command is executed though TRAVIS the command becomes:

composer config --global --auth http-basic.repo.magento.com

And you get the following errors:

  [RuntimeException]                           
  http-basic.repo.magento.com is not defined.                                               

config [-g|--global] [-e|--editor] [-a|--auth] [--unset] [-l|--list] [-f|--file FILE] [--absolute] [--] [<setting-key>] [<setting-value>]...

As the over command tries to fetch the information present in the auth.json file which doesnot exist yet on the TRAVIS server.

bobbyshaw commented 7 years ago

Hmm ok. These variables are set but it seems Travis doesn't export them in PRs for security reasons: https://docs.travis-ci.com/user/pull-requests/#Pull-Requests-and-Security-Restrictions