search

meanbee / magento2-royalmail

[No Longer Supported] A Royal Mail shipping integration for Magento 2.
Open Software License 3.0
5 stars 4 forks source link

Shorten method codes #6

Closed bobbyshaw closed 7 years ago

bobbyshaw commented 7 years ago

Shorten method codes to avoid core Magento issues. Fixes #1 .

bobbyshaw commented 7 years ago

I merged in a separate PR that must have broke those carrier code tests. I ignored travis comments because it seems to be unable to find the the phpunit class in php 7 and haven't debugged a resolution yet.

Do you know that it's a 10 character limit? I've just reduced all the code lengths that I can on a whim because it seems to make it work but I haven't been able to validate the required length.

bobbyshaw commented 7 years ago

@punkstar Any recommendations on how to test when currently I mock the royal mail library in all tests? Should I have a separate instance that doesn’t mock? Technically the shortening is in the new method class which I've imported into the module but this doesn't have any knowledge of what's coming in.

bobbyshaw commented 7 years ago

New test submitted.