search

meandavejustice / min-vid

Popout video player in Firefox
https://testpilot.firefox.com/experiments/min-vid
Mozilla Public License 2.0
182 stars 39 forks source link

Title bar displayed in Linux/GNOME #1137

Open rugk opened 6 years ago

rugk commented 6 years ago

In Firefox 57 with GNOME 3.26 I see that the MinVid window is now an entirely different window than the main Firefox' one. It looks like a modal dialog:

popupminvid

Everything in this window frame (closing, moving around, etc.) works, but I doubt this is how it should look. Especially, as the intended "move around" function (dragging the "video title" with the pointer being a hand) does not work.

FYI: In case it matters, widget.allow-client-side-decoration is enabled, i.e. I use the new "draw in titlebar" mode for the main Firefox window.

Fedora 27, Wayland

SoftVision-CosminMuntean commented 6 years ago

I have managed to reproduce this issue on Fedora 27 x64 with Firefox 57 (1.0) for Fedora, but only if the widget.allow-client-side-decoration boolean pref is set to "true". However, the issue is not reproducible using official Firefox builds, due to the fact that the "widget.allow-client-side-decoration" pref is not available. So probably this is not a Firefox or a Min Vid issue since the pref does not exist on official Firefox builds.

I will leave this issue opened to get more opinions on this.

rugk commented 6 years ago

Wait… I am using the official Fedora builds and widget.allow-client-side-decoration is set to true (it's bold, so manually modified). And I did not create the value manually. (BTW browser.tabs.drawInTitlebar needs to be enabled, too)

Firefox devs implement the titlebar drawing mode for GTK and track it in this issue. So widget.allow-client-side-decoration is an experimental config flag, but currently only enabled in the Fedora build. However, other people running Nightly also already see the dra-in titlebar thing.

imyxh commented 6 years ago

Eh, I noticed this earlier, and I honestly prefer it like this. It means that I can set settings like "always on top" and "always on visible workspace" easily by right-clicking the title bar. Not a big deal if it's removed, though.

Ideally, the user could toggle this in preferences.

rugk commented 6 years ago

It means that I can set settings like "always on top" and "always on visible workspace" easily by right-clicking the title bar.

That's a good point. I don't know how one should set it without the title bar, so mhh… 😐