Clicking the "Mute" and "Unmute" buttons while the player is in error view state wrongly sends pings to telemetry - Githubissues

meandavejustice / min-vid

Popout video player in Firefox

https://testpilot.firefox.com/experiments/min-vid

Mozilla Public License 2.0

182 stars 42 forks source link

Clicking the "Mute" and "Unmute" buttons while the player is in error view state wrongly sends pings to telemetry #1245

Closed SoftVision-CarmenFat closed 6 years ago

SoftVision-CarmenFat commented 6 years ago

[Affected versions]:

Firefox Developer Edition 59.0b7
Firefox Nightly 60.0a1 (02/08/2018)
Min-Vid Shield Study Onboarding 0.4.7 - Shield Study

[Affected Platforms]:

All Windows

[Prerequisites]:

Latest Min-Vid v.0.4.7 Shield Study Onboarding ("active" or "activeAndOnboarding" variant) was previously installed on a clean profile.

[Steps to reproduce]:

Open the browser with the profiles from prerequisites and navigate to YouTube.
Send a video to the mini player that is embedded.
Click the "Mute" button from the player.
Click on the "Unmute" button.
Go to "about:telemetry" and observe if any ping related to the "mute" and "unmute" method is displayed.

[Expected result]:

No pings related to "muting/unmuting" methods are sent to the telemetry.

[Actual result]:

Pings that contain the "mute/unmute" methods are sent to telemetry.

[Notes]:

Since there is no video in the error state view, there is no point on which users should use the volume button. By allowing this to still happen, in the end, this could lead to erroneous metrics results.
Here is a screen recording of the issue:

mute unmute

SoftVision-CarmenFat commented 6 years ago

This issue is no longer reproducible on the latest Shield Study build.