search

meandavejustice / min-vid

Popout video player in Firefox
https://testpilot.firefox.com/experiments/min-vid
Mozilla Public License 2.0
182 stars 42 forks source link

Review minvid bundling process #1272

Closed meandavejustice closed 6 years ago

meandavejustice commented 6 years ago

xpi is 7mb, we should review and make sure we aren't doing anything wild with our bundling technique.

meandavejustice commented 6 years ago

We can probably remove all locales besides en-US for the shield-study

meandavejustice commented 6 years ago 
Archive:  addon.xpi
  Length      Date    Time    Name
---------  ---------- -----   ----
    15847  2018-02-21 22:25   bootstrap.js
        0  2017-12-21 20:03   chrome/
      147  2018-02-15 01:19   chrome.manifest
     1599  2018-02-15 01:19   install.rdf
        0  2018-02-15 01:19   lib/
     1896  2018-02-15 01:19   package.json
        0  2018-02-15 01:19   webextension/
        0  2018-02-15 01:19   chrome/content/
        0  2017-12-21 20:03   chrome/skin/
        0  2017-12-21 20:13   webextension/_locales/
      523  2018-02-15 01:19   webextension/close.svg
        0  2018-02-15 01:27   webextension/content-scripts/
        0  2017-12-21 20:13   webextension/dist/
  6644406  2018-02-15 01:19   webextension/onboarding.gif
      736  2018-02-15 01:19   webextension/manifest.json
        0  2017-12-21 20:05   webextension/options/
   147714  2018-02-15 01:19   lib/StudyUtils.jsm
     4284  2017-12-21 20:05   lib/dragging-utils.js
     4848  2017-12-21 20:05   lib/native-window-utils.js
     4177  2017-12-21 20:05   lib/topify.js
        0  2017-12-21 20:03   lib/vendor/
        0  2017-12-21 20:13   webextension/_locales/ar/
     3038  2017-12-21 20:03   chrome/skin/icon.png
        0  2017-12-21 20:13   webextension/_locales/ast/
        0  2017-12-21 20:13   webextension/_locales/az/
        0  2017-12-21 20:13   webextension/_locales/bn_BD/
        0  2017-12-21 20:13   webextension/_locales/bs/
        0  2017-12-21 20:13   webextension/_locales/cak/
        0  2017-12-21 20:13   webextension/_locales/cs/
        0  2017-12-21 20:13   webextension/_locales/el/
        0  2017-12-21 20:13   webextension/_locales/de/
        0  2017-12-21 20:13   webextension/_locales/en_US/
        0  2017-12-21 20:13   webextension/_locales/es_CL/
        0  2017-12-21 20:13   webextension/_locales/es_ES/
        0  2017-12-21 20:13   webextension/_locales/es_MX/
        0  2017-12-21 20:13   webextension/_locales/fa/
        0  2017-12-21 20:13   webextension/_locales/he/
        0  2017-12-21 20:13   webextension/_locales/fr/
        0  2017-12-21 20:13   webextension/_locales/fy_NL/
        0  2017-12-21 20:13   webextension/_locales/hu/
        0  2017-12-21 20:13   webextension/_locales/id/
        0  2017-12-21 20:13   webextension/_locales/ja/
        0  2017-12-21 20:13   webextension/_locales/it/
        0  2017-12-21 20:13   webextension/_locales/ka/
        0  2017-12-21 20:13   webextension/_locales/kab/
        0  2017-12-21 20:13   webextension/_locales/ko/
        0  2017-12-21 20:13   webextension/_locales/ms/
        0  2017-12-21 20:13   webextension/_locales/nb_NO/
        0  2017-12-21 20:13   webextension/_locales/nn_NO/
        0  2017-12-21 20:13   webextension/_locales/nl/
        0  2017-12-21 20:13   webextension/_locales/pt_BR/
        0  2017-12-21 20:13   webextension/_locales/pt_PT/
        0  2017-12-21 20:13   webextension/_locales/ro/
        0  2017-12-21 20:13   webextension/_locales/sk/
        0  2017-12-21 20:13   webextension/_locales/sl/
        0  2017-12-21 20:13   webextension/_locales/ru/
        0  2017-12-21 20:13   webextension/_locales/sr/
        0  2017-12-21 20:13   webextension/_locales/sq/
        0  2017-12-21 20:13   webextension/_locales/sv_SE/
        0  2017-12-21 20:13   webextension/_locales/te/
        0  2017-12-21 20:13   webextension/_locales/tr/
        0  2017-12-21 20:13   webextension/_locales/zh_TW/
        0  2017-12-21 20:13   webextension/_locales/zh_CN/
        0  2017-12-21 20:13   webextension/_locales/uk/
      460  2017-12-21 20:05   chrome/content/default.html
        0  2017-12-21 20:05   chrome/content/img/
    13503  2018-02-15 01:19   chrome/content/panel.css
  1042896  2018-02-21 22:25   chrome/content/frontend.bundle.js
    47512  2018-02-21 22:25   webextension/dist/background.bundle.js
      720  2017-12-21 20:05   webextension/options/options.js
        0  2018-02-15 01:19   lib/vendor/noitidart-ostypes/
      478  2017-12-21 20:05   webextension/options/options.html
    11603  2018-02-15 01:27   webextension/content-scripts/icon-overlay.js
     4246  2018-02-15 01:19   webextension/content-scripts/onboarding-modal.js
      583  2018-02-21 22:25   webextension/_locales/az/messages.json
     3024  2018-02-21 22:25   webextension/_locales/ar/messages.json
     2682  2018-02-21 22:25   webextension/_locales/bs/messages.json
     2603  2018-02-21 22:25   webextension/_locales/ast/messages.json
     2721  2018-02-21 22:25   webextension/_locales/cak/messages.json
     2791  2018-02-21 22:25   webextension/_locales/cs/messages.json
     3850  2018-02-21 22:25   webextension/_locales/el/messages.json
     3037  2018-02-21 22:25   webextension/_locales/de/messages.json
     2779  2018-02-21 22:25   webextension/_locales/es_CL/messages.json
     2575  2018-02-21 22:25   webextension/_locales/en_US/messages.json
     3034  2018-02-21 22:25   webextension/_locales/fr/messages.json
     2758  2018-02-21 22:25   webextension/_locales/es_ES/messages.json
     3444  2018-02-21 22:25   webextension/_locales/fa/messages.json
     3924  2018-02-21 22:25   webextension/_locales/bn_BD/messages.json
     3151  2018-02-21 22:25   webextension/_locales/he/messages.json
     2878  2018-02-21 22:25   webextension/_locales/hu/messages.json
     2802  2018-02-21 22:25   webextension/_locales/fy_NL/messages.json
     2687  2018-02-21 22:25   webextension/_locales/id/messages.json
     2818  2018-02-21 22:25   webextension/_locales/it/messages.json
     2716  2018-02-21 22:25   webextension/_locales/kab/messages.json
     3136  2018-02-21 22:25   webextension/_locales/ja/messages.json
     4145  2018-02-21 22:25   webextension/_locales/ka/messages.json
     2665  2018-02-21 22:25   webextension/_locales/ms/messages.json
     2621  2018-02-21 22:25   webextension/_locales/nb_NO/messages.json
     2849  2018-02-21 22:25   webextension/_locales/nl/messages.json
     2824  2018-02-21 22:25   webextension/_locales/ko/messages.json
     2527  2018-02-21 22:25   webextension/_locales/nn_NO/messages.json
     2771  2018-02-21 22:25   webextension/_locales/pt_BR/messages.json
     2634  2018-02-21 22:25   webextension/_locales/pt_PT/messages.json
     2736  2018-02-21 22:25   webextension/_locales/ro/messages.json
     2879  2018-02-21 22:25   webextension/_locales/sk/messages.json
     3699  2018-02-21 22:25   webextension/_locales/ru/messages.json
     3297  2018-02-21 22:25   webextension/_locales/sr/messages.json
     2689  2018-02-21 22:25   webextension/_locales/sq/messages.json
     2797  2018-02-21 22:25   webextension/_locales/sl/messages.json
     2711  2018-02-21 22:25   webextension/_locales/sv_SE/messages.json
     4563  2018-02-21 22:25   webextension/_locales/te/messages.json
     2793  2018-02-21 22:25   webextension/_locales/tr/messages.json
     3626  2018-02-21 22:25   webextension/_locales/uk/messages.json
     2604  2018-02-21 22:25   webextension/_locales/zh_CN/messages.json
     2643  2018-02-21 22:25   webextension/_locales/zh_TW/messages.json
      526  2017-12-21 20:05   chrome/content/img/Play-gray.svg
      533  2017-12-21 20:05   chrome/content/img/Add-gray.svg
      593  2017-12-21 20:05   chrome/content/img/add.svg
      831  2017-12-21 20:05   chrome/content/img/audio-thumbnail.svg
      540  2017-12-21 20:05   chrome/content/img/close-menu.svg
      211  2017-12-21 20:03   chrome/content/img/close.svg
      852  2017-12-21 20:05   chrome/content/img/drag.svg
      303  2017-12-21 20:03   chrome/content/img/exit-close.svg
      653  2017-12-21 20:03   chrome/content/img/exit-replay.svg
     1758  2017-12-21 20:05   chrome/content/img/loading-bars.svg
      455  2017-12-21 20:03   chrome/content/img/maximize.svg
      456  2017-12-21 20:03   chrome/content/img/minimize.svg
      715  2017-12-21 20:03   chrome/content/img/move-icon.svg
      305  2017-12-21 20:03   chrome/content/img/mute.svg
      777  2017-12-21 20:05   chrome/content/img/next.svg
      520  2017-12-21 20:05   chrome/content/img/open-menu.svg
      178  2017-12-21 20:03   chrome/content/img/pause.svg
      271  2017-12-21 20:05   chrome/content/img/play-blue.svg
      267  2017-12-21 20:03   chrome/content/img/play.svg
      878  2017-12-21 20:05   chrome/content/img/prev.svg
     1406  2017-12-21 20:05   chrome/content/img/repeat.svg
    45194  2017-12-21 20:03   chrome/content/img/static-static.png
   110724  2017-12-21 20:03   chrome/content/img/static.png
      431  2017-12-21 20:03   chrome/content/img/to-tab.svg
      638  2017-12-21 20:03   chrome/content/img/unmute.svg
      699  2017-12-21 20:05   chrome/content/img/video-thumbnail.svg
    19652  2018-02-15 01:19   lib/vendor/noitidart-ostypes/cutils.jsm
   168976  2017-12-21 20:05   lib/vendor/noitidart-ostypes/ostypes_win.jsm
    82116  2017-12-21 20:05   lib/vendor/noitidart-ostypes/ostypes_mac.jsm
   172361  2017-12-21 20:05   lib/vendor/noitidart-ostypes/ostypes_x11.jsm
     2753  2018-02-21 22:25   webextension/_locales/es_MX/messages.json
---------                     -------
  8687271                     146 files
jaredhirsch commented 6 years ago

@meandavejustice looks like onboarding.gif is the culprit?

6644406 2018-02-15 01:19 webextension/onboarding.gif

meandavejustice commented 6 years ago

@6a68 yikes, we should try and optimize

meandavejustice commented 6 years ago

Gif was made smaller in https://github.com/meandavejustice/min-vid/commit/93ec4dfd187a14864cfeb75180392c8627adf087 closing