search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
473 stars 178 forks source link

Angular config subgenerator and test added #158

Closed UndeadBaneGitHub closed 8 years ago

codydaig commented 8 years ago

LGTM

@ilanbiala LGTY?

ilanbiala commented 8 years ago

LGTM other than that extra newline.

codydaig commented 8 years ago

@UndeadBaneGitHub Can you remove the extra new line so we can merge this in? Thanks!

UndeadBaneGitHub commented 8 years ago

Yep, in couple of hours I will remove it and fix the remaining three PRs as well. Commits should be squashe as they used to be, correct?

On Saturday, 9 January 2016, Cody B. Daig notifications@github.com wrote:

@UndeadBaneGitHub https://github.com/UndeadBaneGitHub Can you remove the extra new line so we can merge this in? Thanks!

— Reply to this email directly or view it on GitHub https://github.com/meanjs/generator-meanjs/pull/158#issuecomment-170269934 .

codydaig commented 8 years ago

Yup!

UndeadBaneGitHub commented 8 years ago

Fixed and squashed!

codydaig commented 8 years ago

LGTM