search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
473 stars 178 forks source link

Express route subgenerator and test added #168

Closed UndeadBaneGitHub closed 8 years ago

codydaig commented 8 years ago

Left a line comment. Don't forget to squash. Otherwise, LGTM.

UndeadBaneGitHub commented 8 years ago

As an experiment, changed it to the "prompt for name, if left blank inherit it from module" behavior. @ilanbiala @codydaig Take a look, please - if it's fine, I can do likewise in all the other generators.

mleanos commented 8 years ago

@UndeadBaneGitHub I'm not sure that we should overwrite an existing file. That could be disastrous when the user accidentally left this prompt blank.

Can we check to see if a file exists, before overwriting it? What are our options of notifying the user, or handling, when the file exists?

UndeadBaneGitHub commented 8 years ago

@mleanos Yo actually prompts for overwrite if it finds that there is such a file - that's why there's no explicit check

codydaig commented 8 years ago

@ilanbiala LGTY?

UndeadBaneGitHub commented 8 years ago

@codydaig @ilanbiala I'we performed "last swipe" and fixed the remaining pinpointed issues (scope -> $scope). If no more are discovered, I hope the PRs to get merged :) After that I can start working on CRUD + ACL (the trickiest one) generators.

ilanbiala commented 8 years ago

LGTM.