search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
473 stars 178 forks source link

Express tests subgenerator and test added #169

Closed UndeadBaneGitHub closed 8 years ago

codydaig commented 8 years ago

@ilanbiala LGTY?

ilanbiala commented 8 years ago

@codydaig just moving timeout to Gulp task, other than that I think it's fine, but once that is removed I'll look them all over again.

UndeadBaneGitHub commented 8 years ago

@ilanbiala Actually, let me suggest to merge them before the timeout(0) removal. The thing is, fixing it in 13 branches => pushing the commits => squashing the commits takes a ton of time. Maybe, merge it with the timeout, and then add a PR removing it in all the tests at once?

ilanbiala commented 8 years ago

Ok sounds good. @codydaig LGTM.

UndeadBaneGitHub commented 8 years ago

@ilanbiala @codydaig I know it's Christmas and everything (Merry Xmas by the way), but how about a merge? :)

codydaig commented 8 years ago

@UndeadBaneGitHub @ilanbiala Merged! Thanks!!

UndeadBaneGitHub commented 8 years ago

@codydaig Yay! Great! 12 more to go ^_^