search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
473 stars 178 forks source link

Test infrastructure #173

Closed ilanbiala closed 8 years ago

ilanbiala commented 8 years ago

WIP Fixes #172

ilanbiala commented 8 years ago

@codydaig tests are passing, but does that guarantee the JSHint and ESLint are actually running?

Once everything is finalized and reviewed, I'll squash and rebase.

mleanos commented 8 years ago

LGTM

ilanbiala commented 8 years ago

@codydaig if LGTY as well, I'll squash and merge.

codydaig commented 8 years ago

@ilanbiala Sorry for the delay. Traveling this week. It looks as though they are passing.

LGTM

UndeadBaneGitHub commented 8 years ago

@ilanbiala This one does not solve timeouts problem. I have removed this.timeout(0) in all the tests - and they started to fail whenever git pull is involved, as it takes quite some time from where I am.

I am currently trying to find a solution for this problem

UPD Setting timeout to Infinity did help. I will push the update shortly.