meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
473 stars 178 forks source link

CRUD module with unit tests #175

Closed keithics closed 8 years ago

keithics commented 8 years ago

screen shot 2015-12-26 at 2 39 38 pm

tbaustin commented 8 years ago

Hello, how can we generate a new crud module from cmd line?

keithics commented 8 years ago

yo meanjs:crud-module <module-name>

mbbaig commented 8 years ago

Is this going to be merged anytime soon?

I am using MEANJS 0.4.2 right now and assume that the generator of the same version will soon be released. Since the generators are keeping up with the core MEAN framework.

I need the CRUD generation module. Will this be available in the next release?

tbaustin commented 8 years ago

I tried yo meanjs:crud-module and got:

Error meanjs:crud-module customers

You don't seem to have a generator with the name meanjs:crud-module installed. You can see available generators with npm search yeoman-generator and then install them with npm install [name]. To see the 2 registered generators run yo with the --help option.

tbaustin commented 8 years ago

@keithics Look at the comment above

keithics commented 8 years ago

@tbaustin it hasn't been merged yet.

@mbbaig @tbaustin you can try my fork for 0.4.2 for the meantime. I have been using it for some time now. https://github.com/webninjamobile/generator-meanjsplus

tbaustin commented 8 years ago

@keithics How exactly do we use your branch sorry kind of new to a lot of this stuff with node and github.

keithics commented 8 years ago

@tbaustin remove the old generator then clone the forked repo. then do npm link. You may need to run npm install in order to run it.

http://yeoman.io/authoring/index.html .. see Running the generator

tbaustin commented 8 years ago

@keithics can i just download the zip and run it from that folder ? So I dont have to start all over on my project(I can wait till they get theirs working on it and just make a new one). Then would I just run npm install and then npm link?

keithics commented 8 years ago

@tbaustin yes, download.. unzip. cd to that folder. npm install and npm link. if you have the old generator, you need to remove it.

tbaustin commented 8 years ago

@keithics How do i remove the old generator ?

ilanbiala commented 8 years ago

@keithics did an initial review. It looks pretty good, though the style of the code needs to be updated once we finalize a couple modules in the main repo that you can refer to and copy from.

@codydaig did I miss anything in the initial review?

keithics commented 8 years ago

thanks @ilanbiala let me know once the modules are finalized.

tbaustin commented 8 years ago

@keithics When I type grunt in the cmd it does not work. I just made a completely new project and cloned your fork using git clone ~.

jpimentel commented 8 years ago

Still waiting for this

codydaig commented 8 years ago

@keithics Most of the modules have been merged in, and the remaining few are almost done. You can look at those for styles and what not. Let us know when you've addressed the above comments from @ilanbiala and resolve the conflicts and we can go into a more detailed review.

keithics commented 8 years ago

@codydaig will take a look at it now. thanks.

trendzetter commented 8 years ago

I am interested to test it

keithics commented 8 years ago

@trendzetter please feel free to test it..

trendzetter commented 8 years ago

I was about to and then I realized that this would still produce "old style" modules. I am thinking about updating it to make it produce new modules, seems quite a bit of change though. But setting up modules manually is also laborious

UndeadBaneGitHub commented 8 years ago

@trendzetter CRUD generator for new style (both folders AND codestyle itself) is in https://github.com/meanjs/generator-meanjs/pull/201

This PR will get closed as soon as https://github.com/meanjs/generator-meanjs/pull/201 is merged, I suppose.

codydaig commented 8 years ago

@keithics Thanks for the hard work! We decided to merge @UndeadBaneGitHub's PR because it matched the latest style guide. Again, thanks for the hard work, and I hope to see more PRs from you in the future!

keithics commented 8 years ago

awesome! No worries guys.