MEAN module subgenerator and test added

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator

http://meanjs.org/

473 stars 178 forks source link

MEAN module subgenerator and test added #185

Closed UndeadBaneGitHub closed 8 years ago

UndeadBaneGitHub commented 8 years ago

In this PR I have addressed all the issues, that were around in the previous one, plus

Added Underscore library to dependencies for its extend function
Reworked this.prompt and following folders creation function to be less verbose
Completely isolated client and server folder prompts from each other in objects
Added tests for folder existence

In such state this generator looks like a good CRUD generator base to me, along with it being a standalone one.

ilanbiala commented 8 years ago

Nice changes, overall definitely good improvements. Once we resolve the 2 comments above, LGTM.

codydaig commented 8 years ago

@UndeadBaneGitHub @ilanbiala Checking the status of this PR? I'd love to see a release with this PRs in the coming days.

UndeadBaneGitHub commented 8 years ago

I will update it tomorrow midday ECT and fix the remaining stuff.

On Tuesday, 19 January 2016, Cody B. Daig notifications@github.com wrote:

@UndeadBaneGitHub https://github.com/UndeadBaneGitHub @ilanbiala https://github.com/ilanbiala Checking the status of this PR? I'd love to see a release with this PRs in the coming days.

— Reply to this email directly or view it on GitHub https://github.com/meanjs/generator-meanjs/pull/185#issuecomment-172687648 .

UndeadBaneGitHub commented 8 years ago

@codydaig @ilanbiala Updated it just like I promised to! Yay for the new version :+1:

codydaig commented 8 years ago

LGTM

ilanbiala commented 8 years ago

LGTM.