search

meanjs / generator-meanjs

MEAN.JS Official Yeoman Generator
http://meanjs.org/
473 stars 178 forks source link

Add support for non rm -rf supported command prompts #186

Closed ilanbiala closed 8 years ago

ilanbiala commented 8 years ago

@codydaig Windows in particular, should finally resolve https://github.com/meanjs/generator-meanjs/issues/118

codydaig commented 8 years ago

@mleanos Can you give this a shot on Windows? Thanks!

UndeadBaneGitHub commented 8 years ago

Testing that on Windows right now. I actually suggest adding additional assertions assert.noFile to the tests to be absolutely sure the folders are properly deleted.

codydaig commented 8 years ago

@UndeadBaneGitHub I'd love to get additional test coverage. However, I think that should be a separate PR. Let us know how it does on windows!

UndeadBaneGitHub commented 8 years ago

@codydaig @ilanbiala Looks ok on my Windows 10. However, my tests, checking contents of the files for routes fail. I strongly suspect, it is because I use \n as a newline character, and for Windows it is \r\n. But that's a completely different story, and I will address it in "fix timeout(0), temp folder and stuff" PR that's coming today later in the evening.

ilanbiala commented 8 years ago

@UndeadBaneGitHub try using https://nodejs.org/dist/latest-v4.x/docs/api/os.html#os_os_eol to get it working independent of OS.

Can you add the asserts for no file to your PR as well?

UndeadBaneGitHub commented 8 years ago

@ilanbiala Yep, I will add them there too